search

scalacenter / scoop-bloop

Apache License 2.0
0 stars 4 forks source link

Windows paths with spaces not supported #5

Closed er1c closed 4 years ago

er1c commented 4 years ago 
PS C:\Users\Eric Peters> bloop about
C:\Users\Eric Peters\scoop\apps\python\current\python.exe: can't find '__main__' module in 'C:\\Users\\Eric'

Looks like something isn't quoted properly to handle paths with spaces.

original bloop.cmd

@echo off
python C:\Users\Eric Peters\scoop\apps\bloop\1.3.4\bloop %*

Changing to

@echo off
python "C:\Users\Eric Peters\scoop\apps\bloop\1.3.4\bloop" %*`

Fixes the problem, I'm not entirely sure where this file is coming from/how it is generated.

Version scoop install bloop - 1.3.4

jvican commented 4 years ago

Would you mind sending a PR to fix this @er1c ? Sorry, I didn't get to see this ticket.

er1c commented 4 years ago

@jvican I'm not actually sure howto fix it

er1c commented 4 years ago

Hmm looks like it's from: https://github.com/scalacenter/bloop/releases/download/v1.4.0-RC1/install.py

er1c commented 4 years ago

Added https://github.com/scalacenter/bloop/pull/1131