scalajs-react-interface / sri

Apache License 2.0
151 stars 8 forks source link

Publish plugin for SBT 1.x #15

Open n3ziniuka5 opened 6 years ago

n3ziniuka5 commented 6 years ago

The lack of sbt 1.x support means you cannot use this in a multi-project build, unless the whole project is on older sbt.

frgomes commented 6 years ago

I vote for SBT 1.x.

frgomes commented 6 years ago

@virtualirfan @chandu0101:

Migrating sbt-sri-platform requires review of several other projects:

Milestone 2018.10.0-M1

Update sbt-sri-platform, mobile.g8 and other projects:

chandu0101 commented 6 years ago

cross compile 2.10, 2.11, 2.12

why 2.10, 2.11 ? , let force community to move forward .. , i'll vote 2.13 cross compile

provide version.sbt and review interdependencies (from the light of sbt-dynver

sbt-dynver is needed , it fetches version number from git tag in travis builds...

frgomes commented 6 years ago

@chandu0101 : I've cross compiled scalajs-jest/core and scalajs-plus/core on 2.11 and 2.12 already. Apparently it is OK but I'm not skilled enough on jest to tell for sure. I will cross compile to 2.13 as soon as dependencies are satisfied.

Yes, sbt-dynver is the way to go. However, at this point, it's easier for me to hardcode the version. After everything works as designed, I will focus only on making things fit well with tags and sbt-dynver.