Make sealed trait/enum matching order deterministic

scalalandio / chimney

Scala library for boilerplate-free, type-safe data transformations

https://chimney.readthedocs.io

Apache License 2.0

1.15k stars 91 forks source link

Make sealed trait/enum matching order deterministic #543

Closed reimai closed 3 months ago

reimai commented 3 months ago

Classfiles of generated transformers are slightly different, the order of sealed subclasses is non-deterministic. We're using bazel as a build tool and it's important for build to produce an exact same file for the same input, otherwise it's dependent targets are re-evaluated.

MateuszKubuszok commented 3 months ago

Thanks again for the fix! 🙏

Since we already updated Scala 2.13 stdlib to 2.13.14 (which slightly changes the contracts) I'd like the next release to be 1.1.0, and I would also like to merge Scala Native 0.5.1 support with it, which is currently blocked.

Once I'll be able to merge it, I'll publish your changes as part of 1.1.0.

MateuszKubuszok commented 3 months ago

Released as 1.1.0