search

scalamacros / paradise

(No longer actively maintained.)
http://scalamacros.org/
BSD 3-Clause "New" or "Revised" License
158 stars 53 forks source link

only add @compileTimeOnly if it is not already defined #91

Closed Philippus closed 7 years ago

Philippus commented 7 years ago

solves https://github.com/scalamacros/paradise/issues/90

xeno-by commented 7 years ago

LGTM. Thank you!

xeno-by commented 7 years ago

@Philippus How would you like to see this published? We could cut a 2.1.1 across supported versions of Scala, or we could silently roll this functionality in the 2.1.0 release starting from Scala 2.12.2.

Philippus commented 7 years ago

To me it doesn't sound like a huge problem that warrants a separate release, so I would say put it in the 2.1.0 release. Or does this mean that it will only be fixed for Scala 2.12.2?

Philippus commented 7 years ago

it doesn't look like this was published yet? And we are at the 2.1.0 release.

xeno-by commented 7 years ago

What version of Scala are you using?

Philippus commented 7 years ago

Let's add it to 2.12.2 ?

xeno-by commented 7 years ago

Looks like I didn't cherry-pick this commit to the branches supporting recent versions of Scala. Neither 2.11.11, nor 2.12.2 releases of paradise have this logic :(

I suggest we cut a 2.1.1 release. What do you think?

Philippus commented 7 years ago

Sounds good to me!

xeno-by commented 7 years ago

Published: https://oss.sonatype.org/content/repositories/releases/org/scalamacros/paradise_2.12.2/2.1.1/.

Sorry for the significant delay in responses!