search

scalameta / coc-metals

Deprecated in favor of scalameta/nvim-metals
http://scalameta.org/metals/
Apache License 2.0
167 stars 24 forks source link

Add valid entry to engines field in package.json #414

Closed jsatk closed 3 years ago

jsatk commented 3 years ago

Fixes this warning when running yarn install.

warning coc-metals@1.0.7: The engine "coc" appears to be invalid.

Unfortuantely coc isn't a valid value for engines in package.json. See: https://docs.npmjs.com/cli/v7/configuring-npm/package-json#engines

According to the README for coc.vim (as of this writing) it requires 12.12 or above. See: https://github.com/neoclide/coc.nvim#quick-start

ckipp01 commented 3 years ago

Fixes this warning when running yarn install.

warning coc-metals@1.0.7: The engine "coc" appears to be invalid.

Unfortuantely coc isn't a valid value for engines in package.json. See: https://docs.npmjs.com/cli/v7/configuring-npm/package-json#engines

So even though it's not an official "engine" I'm fairly positive this is still used on the coc side of things to verify that a certain version of coc.nvim is being used. It's pretty common in coc extensions to have this. For example you can see it here in the coc-tsserver which is written by the coc guys. So I think more than anything we need to determine what version of coc.nvim is necessary with for coc-metals and update this value with that instead. We also do something similar in our VS Code extension where we use VS Code as the engine.

According to the README for coc.vim (as of this writing) it requires 12.12 or above. See: https://github.com/neoclide/coc.nvim#quick-start

Ahh, I think one other thing we'll need to do instead of this change here is to also update the CI to not run on version < 12, basically just update the matrix.

jsatk commented 3 years ago

Fixes this warning when running yarn install.

warning coc-metals@1.0.7: The engine "coc" appears to be invalid.

Unfortuantely coc isn't a valid value for engines in package.json. See: https://docs.npmjs.com/cli/v7/configuring-npm/package-json#engines

So even though it's not an official "engine" I'm fairly positive this is still used on the coc side of things to verify that a certain version of coc.nvim is being used. It's pretty common in coc extensions to have this. For example you can see it here in the coc-tsserver which is written by the coc guys. So I think more than anything we need to determine what version of coc.nvim is necessary with for coc-metals and update this value with that instead. We also do something similar in our VS Code extension where we use VS Code as the engine.

According to the README for coc.vim (as of this writing) it requires 12.12 or above. See: https://github.com/neoclide/coc.nvim#quick-start

Ahh, I think one other thing we'll need to do instead of this change here is to also update the CI to not run on version < 12, basically just update the matrix.

Ah. And here I thought I was helping by fixing an easy warning. Thanks for the kind educational lesson.

Ahh, I think one other thing we'll need to do instead of this change here is to also update the CI to not run on version < 12, basically just update the matrix.

Will look into this soon.

Going to close this PR. Will open a new one with that update if I get to it.