scalameta / coc-metals

Deprecated in favor of scalameta/nvim-metals
http://scalameta.org/metals/
Apache License 2.0
167 stars 24 forks source link

Update `TextDocument` import statements #415

Closed jsatk closed 3 years ago

jsatk commented 3 years ago

Warning from tsserver:

[tsserver 6385] [I] 'TextDocument' is deprecated

If you take a look at the actual @deprecated jsdocs it asks you to "Use the text document from the new vscode-languageserver-textdocument package."

jsatk commented 3 years ago

I was exploring the repo and trying to wrap my head around how it all works and came across this low-hanging fruit so figured I'd fix it. If this is too nitpick and inconsequential happy to close.

ckipp01 commented 3 years ago

Out of total curiosity, do you have a different email attached to your global git config than you use on github? I see it is marking your commits on here as "Unverified" and not recognizing that they are you.

jsatk commented 3 years ago

Ah. It’s because I was on my work machine It created the commit itself under private work email and such. But the gh cli tool is correctly pointed at my public GitHub name.

I’ll see if there’s a way to make sure it commits with my public user from my work machine or just never commit from my work machine. (My personal computer is just behind updates and I’ve been putting it off. 😅)

On Aug 5, 2021, at 23:44, Chris Kipp @.***> wrote:

 Out of total curiosity, do you have a different email attached to your global git config than you use on github? I see it is marking your commits on here as "Unverified" and not recognizing that they are you.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

ckipp01 commented 3 years ago

ahhh I figured it was something like this. Ha. I actually have a script on my computer for this exact purpose

#!/usr/bin/env sh

if [ -f "$PWD/.git/config" ]; then
  if [ "$1" == "work" ]; then
    echo "[user]\n\tname = Chris Kipp\n\temail = chris.kipp@lunatech.nl" >> "$PWD/.git/config"
  else
    echo "[user]\n\tname = ckipp01\n\temail = ckipp@pm.me" >> "$PWD/.git/config"
  fi
else
  echo "No .git/config exists here"
fi