search

scalameta / coc-metals

Deprecated in favor of scalameta/nvim-metals
http://scalameta.org/metals/
Apache License 2.0
167 stars 24 forks source link

Update `metals-languageclient` #416

Open ckipp01 opened 3 years ago

ckipp01 commented 3 years ago

Task

When coc-metals and metals-languageclient were first written they were compliant with the LSP 3.15.0 spec. Now that we are on 3.16.0, coc.nvim has update here https://github.com/neoclide/coc.nvim/commit/70a7903e114b8bd4a6eb9add9f7a60da77cb1938 and metals-languageclient here https://github.com/scalameta/metals-languageclient/commit/5980c679cda22aa7417a1bf1da5d59617110b7b4. We should update our version of metals-languageclient to the latest and also make any changes necessary to work with 3.16.0.

Additional context

You can see what was needed in the VS Code extension to do this update here: https://github.com/scalameta/metals-vscode/commit/7c46dca3a6cc5324b44dcecf60bf97b8f661588f

Search terms

3.16.0

ckipp01 commented 2 years ago

Note that this is increasingly important now as the latest Metals is being built with 2.13 instead of 2.12. In order for coc-metals correctly pull the right version of Metals this update needs to happen or you won't be able to use the latest snapshots or the next stable version.