Closed Quafadas closed 3 months ago
@tgodzik - Sorry to bother. There's honestly no rush, just want to give a little nudge if you had a moment...
No worries, I think I missed the notitfication :-/ ... I've tried to work through the comments you've raised above.
Thankyou very much for review 🙏 .
Huh, I have no idea, why that change should fail the CI. I think maybe it just needs rerunning ... odd.
The failure looks unrelated, somehow coursier is not working well on windows. We might need to rework the test or ignore it on Windows.
Thanks again for looking -
Thanks again for looking -
Sorry it took so long :sweat:
I rebased this onto main... hopefully, CI goes green...
@tgodzik Got CI green again :-)...
Och, I somehow lost track of the PR :fearful: @Quafadas do you want me to merge?
No worries - I think so yes please if it's okay.
@tgodzik Thankyou! I'm just getting around to checking now - but I think it looks like you've done everything for me.
🙏
Thankyou again.
This seems to pass tests locally.