search

scalameta / mdoc

Typechecked markdown documentation for Scala
https://scalameta.org/mdoc/
Apache License 2.0
394 stars 80 forks source link

JS preserve extra modifiers #834

Closed Quafadas closed 3 months ago

Quafadas commented 7 months ago

This seems to pass tests locally.

Quafadas commented 7 months ago

@tgodzik - Sorry to bother. There's honestly no rush, just want to give a little nudge if you had a moment...

Quafadas commented 6 months ago

No worries, I think I missed the notitfication :-/ ... I've tried to work through the comments you've raised above.

Thankyou very much for review 🙏 .

Quafadas commented 6 months ago

Huh, I have no idea, why that change should fail the CI. I think maybe it just needs rerunning ... odd.

tgodzik commented 6 months ago

The failure looks unrelated, somehow coursier is not working well on windows. We might need to rework the test or ignore it on Windows.

Quafadas commented 6 months ago

Thanks again for looking -

tgodzik commented 6 months ago

Thanks again for looking -

Sorry it took so long :sweat:

Quafadas commented 6 months ago

I rebased this onto main... hopefully, CI goes green...

Quafadas commented 6 months ago

@tgodzik Got CI green again :-)...

tgodzik commented 3 months ago

Och, I somehow lost track of the PR :fearful: @Quafadas do you want me to merge?

Quafadas commented 3 months ago

No worries - I think so yes please if it's okay.

Quafadas commented 3 months ago

@tgodzik Thankyou! I'm just getting around to checking now - but I think it looks like you've done everything for me.

🙏

Thankyou again.