search

scalameta / metals-feature-requests

Issue tracker for Metals feature requests
37 stars 4 forks source link

Go to implementation for dependency sources #119

Closed Z1kkurat closed 8 months ago

Z1kkurat commented 4 years ago

Describe the bug VSCode + Metals fails to find trait implementations in dependency's source files, for Doobie in particular (when using in project that depends on doobie as a dependency).

To Reproduce Steps to reproduce the behavior:

  1. Any project which has doobie dependency will do
  2. Go to sources, in particular doobie.free.preparedstatement
  3. Right-click on trait Visitor inside object PreparedStatementOp, choose Go to implementations
  4. See No implementation found for Visitor

Expected behavior Implementations are shown in pop-up window. If you try to do this while in doobie's source repository, it works fine. Clean compiles don't help either.

Screenshots image

Installation:

Search terms doobie

tgodzik commented 4 years ago

Thanks for reporting! That is currently expected, since we don't index the inheritance graph inside the dependencies. It would be a good improvement for sure, but it might be quite hard to achieve efficiently.

Z1kkurat commented 3 years ago

@tgodzik Are there any plans to support this? This would be a really game-killer feature IMHO. I think many users currently have to switch to IDEA to get that functionality.

tgodzik commented 3 years ago

There are certainly plans, but we've not been able to work on it just yet. It also depends on https://github.com/scalameta/metals/issues/1287 which should allow us to effectively query the classpath.

tgodzik commented 8 months ago

This is now working for both Scala and Java