search

scalameta / metals-sublime

Sublime Text package for Metals, a language server for Scala
https://packagecontrol.io/packages/LSP-metals
Apache License 2.0
16 stars 10 forks source link

In the completions widget, a lot of duplicated information is shown for every entry #112

Closed frou closed 1 year ago

frou commented 1 year ago

Hi there - a picture shows it best:

Screenshot 2023-06-17 at 12 49 06

They should probably only be shown on the right side.

Most ST LSP completion widgets for other languages are not super wide like this.

ST 4143 LSP v1.24.0 LSP-metals v0.17.4

ayoub-benali commented 1 year ago

Hi, the completion logic is done in the LSP package. @rchl @rwols was there any change in the completion implementation?

rchl commented 1 year ago

There was a couple months ago. Is there a special logic applied for ST? How does it look in vscode?

frou commented 1 year ago

Here's what it looks like in VSC. IMHO it's not very well presented either

Screenshot 2023-06-17 at 17 41 55

I don't know whether there's a regression or not, because today is the first time I've tried Metals

rchl commented 1 year ago

To me it looks pretty much the same in the sense that the "annotation" repeats what is already included in the completion's text. Only that VSCode shows "annotation" only for the selected item, it seems. So it looks like something that should be addressed in the server and not specific to ST.

frou commented 1 year ago

It's a problem with the Metals server itself. See here on their feature request repo: https://github.com/scalameta/metals-feature-requests/issues/235