search

scalameta / metals-sublime

Sublime Text package for Metals, a language server for Scala
https://packagecontrol.io/packages/LSP-metals
Apache License 2.0
16 stars 10 forks source link

Remove internal settings from the LSP-metals.sublime-settings #60

Open ayoub-benali opened 2 years ago

ayoub-benali commented 2 years ago

This file is editable by the user to tweak Metals behavior but it should not contain things like initializationOptions and other internal values

rchl commented 2 years ago

Should or should not contain internal things?

Note that initializationOptions are typically not considered internal as user might want to tweak those in some cases. But not sure about this server specifically.

ayoub-benali commented 2 years ago

Typo sorry, I meant "should not".

I think mixing the server settings with settings internal to the package like "selector": "source.scala", and initializationOptions are confusing. The user should be able to disable things like decorations, etc without having to fiddle with provider values.

rchl commented 2 years ago

At least for some servers it makes sense to expose selector to allow the user to enable server on more file types. For example makes sense for LSP-eslint. Also initializationOptions in some cases control opinionated features that the user might want to toggle.

But you do as you wish. Maybe it makes sense for this server.