search

scalameta / metals-sublime

Sublime Text package for Metals, a language server for Scala
https://packagecontrol.io/packages/LSP-metals
Apache License 2.0
16 stars 10 forks source link

Handle new doctor format #86

Closed ayoub-benali closed 1 year ago

ayoub-benali commented 2 years ago

Example here: https://github.com/scalameta/nvim-metals/pull/321

ninth-dev commented 2 years ago

hi @ayoub-benali, I had a go with handling the new doctor format.

There was some issues with aligning the emojis with the current approach.

See here :

metals-doctor-update

https://github.com/scalameta/metals-sublime/compare/master...ninth-dev:handle-doctor-new-format

I used a different approach similar to what was in nvim-metals.

metals-doctor-non-tabular

https://github.com/scalameta/metals-sublime/compare/master...ninth-dev:handle-doctor-new-format-non-tabular

Please let me know what you think ~ Happy to raise the PR and clean it up where necessary :)

Thanks!

ayoub-benali commented 2 years ago

Thanks for looking into it @ninth-dev ! I have no problem switching the table as long as it provides the same features :)

The only thing that seems to be missing from the changes is something like this: https://github.com/scalameta/nvim-metals/blob/d4cf4609786beb26e640888dfde9032f5872d264/lua/metals/doctor.lua#L73

We basically have to account for 3 versions of doctor so far

Please don't hesitate the open a PR

ayoub-benali commented 1 year ago

Implemented in https://github.com/scalameta/metals-sublime/pull/93