search

scalameta / metals-vscode

Visual Studio Code extension for Metals
https://marketplace.visualstudio.com/items?itemName=scalameta.metals#overview
Apache License 2.0
297 stars 74 forks source link

Prefer the metals VSCode extension to run in the "Workspace" as opposed to "UI" #1515

Closed Quafadas closed 1 month ago

Quafadas commented 1 month ago

I've been experimenting with using metals in codespaces.

Under certain conditions (e.g. firewalls), I believe the metals extension may struggle to communicate with it's build server if running in the on the UI side of the architecture.

This change says "I prefer to run in the workspace (i..e next to the code, and where the build server also wants to be), but I can run on the UI side if you want me to". I think metals might also work in the UI under this architecture under permissive network conditions, so I have't chosen to prevent the UI side entirely.

I've had to manually set this flag a few times now, and I think it's more likely that metals will work better as a workspace extension universally, so I'm putting up for a PR as part of the extension manifest.

Here is what I believe the relevant docs are;

https://code.visualstudio.com/api/advanced-topics/remote-extensions#architecture-and-extension-kinds

https://code.visualstudio.com/api/advanced-topics/extension-host#preferred-extension-location

https://code.visualstudio.com/api/references/extension-manifest

Quafadas commented 1 month ago

Thanks for the tip ... I just spent a few minutes trying to figure out prettier! Wrong starting point :-)...

change in bound.

Quafadas commented 1 month ago

That got it 🙏