search

scalameta / metals-vscode

Visual Studio Code extension for Metals
https://marketplace.visualstudio.com/items?itemName=scalameta.metals#overview
Apache License 2.0
299 stars 75 forks source link

feature: Also run plain Java when noDebug from launch.json #1521

Closed tgodzik closed 1 month ago

tgodzik commented 1 month ago

Previously, if user run code from code lenses they would get a java command running without DAP. However, if they wanted to add parameters and run via launch.json they would run it via DAP.

Now, even if running from configuration we will run with simple java command. One issue here is that we need to start debugger anyway of run via launch.json, but I worked around it by just running echo instead.

Needs https://github.com/scalameta/metals/pull/6306

tgodzik commented 1 month ago

This should be good to review now.

kasiaMarek commented 1 month ago

But https://github.com/scalameta/metals/pull/6306 was merged after the release. Or do you mean just so it's reviewed?

tgodzik commented 1 month ago

I just meant if you could take a look at it, no pressure. Will include it in the next release.