search

scalameta / metals-zed

Zed plugin for Metals
Apache License 2.0
45 stars 10 forks source link

Pass shell env to metals #18

Closed WeetHet closed 3 weeks ago

WeetHet commented 1 month ago

Fixed environment not being passed to metals, breaking local nix-based installations

tgodzik commented 1 month ago

@hmemcpy anything against the change?

hmemcpy commented 1 month ago

Absolutely not, please go ahead! I apologize, I don't have enough capacity to maintain this extention lately, so any changes are welcome :)

WeetHet commented 1 month ago

Wait, please test it first. I can't build dev extensions for some reason so I'm not sure if it works :)

tgodzik commented 1 month ago

Anyone has it setup and can quickly check? I am afraid I will not have time to do it.

WeetHet commented 1 month ago

Anyone has it setup and can quickly check? I am afraid I will not have time to do it.

Okay, I've borrowed a friend's laptop, and it seems to be working fine, feel free to merge. Also, we need to make a PR to the extensions repo to update the extension, do I do it, or would you do that?

tgodzik commented 3 weeks ago

Anyone has it setup and can quickly check? I am afraid I will not have time to do it.

Okay, I've borrowed a friend's laptop, and it seems to be working fine, feel free to merge. Also, we need to make a PR to the extensions repo to update the extension, do I do it, or would you do that?

It would be cool if you could, thanks!

filipwiech commented 2 weeks ago

@tgodzik Hey, I have pushed an update to the Zed extensions repository to update Scala plugin to the current version 0.0.4 (at the commit b8ae0d4). Just letting you know, since you might probably want to tag it here, like the previous releases. :+1:

tgodzik commented 2 weeks ago

Thanks! Added