"Insert type annotation" available in vim ?

[achever1]

Hello !

I can't figure out how to have the "Insert type" action in vim. It doesn't appear in the choices. Is it expected ?

OS: Linux vim version: NVIM v0.5.0 node version: v12.22.0 coc.nvim version: 0.0.80-aa24232066 coc-metals: 1.0.7 scala: 2.13.5

Originally posted by @armeltd in https://github.com/scalameta/metals/issues/2875#issuecomment-880171397

[tgodzik]

Thanks for reporting! It looks like the position sent to Metals is that of "tot" as the code action suggests the Convert to interpolation string code action. Any idea what's going here @ckipp01 ?

[ckipp01]

@armeltd are you able to post your mapping that you're using to trigger the code action?

[achever1]

Issue fixed indeed it was a binding issue. Here's what I had :

" Remap for do codeAction of current line
xmap <leader>a  <Plug>(coc-codeaction-line)
nmap <leader>a  <Plug>(coc-codeaction-line)

I think I copy pasted them a couple of months ago from the metals website.

the default bindings have changed now (line => selected) and it works when I get the new ones :

" Applying codeAction to the selected region.
" Example: `<leader>aap` for current paragraph
xmap <leader>a  <Plug>(coc-codeaction-selected)
nmap <leader>a  <Plug>(coc-codeaction-selected)

Thanks for all what your doing it is really awesome. :+1:

[ckipp01]

Glad it's fixed. If you are able to, please do shoot in a PR to update the bindings, which can be found here: https://github.com/scalameta/metals/blob/main/docs/editors/vim.md#recommended-cocnvim-mappings. I'll go ahead and leave this open a bit until we get the mappings updated. If you don't have time I should be able to quickly do it later today.

[achever1]

The default mappings on the site now are working so they don't need any update. it is just the old ones at the time I copy pasted that were not. It is just to "old users" to remind to update their conf sometimes. Maybe this kind of required action could be notified to users in some way (release note ?) because updating the conf is not something I thought about. Now I will :D but I don't know if everyone will.

[ckipp01]

Ahh ok, sounds good. I'll go ahead and close then. I'll try to think of a better way on the coc-metals side to notify users, but I'm not always aware of the changes coc.nvim makes on their end. 👍🏼

[otto-dev]

Saw this a couple hours late. For googlers: The correct mapping for normal mode is

nmap <Space>a  <Plug>(coc-codeaction-cursor)

you may replace <Space>a of course

[achever1]

ok done. then I suggest to update the doc https://github.com/scalameta/metals/pull/2985