search

scalameta / metals

Scala language server with rich IDE features 🚀
https://scalameta.org/metals/
Apache License 2.0
2.1k stars 332 forks source link

Mention required VSCode plugins in the installation instructions #299

Closed kubukoz closed 6 years ago

laughedelic commented 6 years ago

I think those plugins are supposed to be installed automatically. Doesn't it work when you run it in debug mode?

kubukoz commented 6 years ago

I ran it in debug mode and for some reason I didn't have them (an error was showing up in the debugged instance)

laughedelic commented 6 years ago

OK. Could you submit a PR adding missing steps to the docs?

kubukoz commented 6 years ago

Sure, I'll just check if it was something env-specific (I may have had the Scala plugin installed and removed before) and follow up with a PR

gabro commented 6 years ago

Just a quick update on this: the report is correct. The required dependencies are not installed automatically in dev (the dotty LSP extension faced the same issue)

kubukoz commented 6 years ago

I think the code outline extension is now unavailable, too :/

gabro commented 6 years ago

That's been integrated directly in VSCode starting from v1.24. Once the work on the VSCode extension starts again, we can remove that dependency.

gabro commented 6 years ago

Actually, it's already gone on master.

olafurpg commented 6 years ago

package.json has a dependency on scala-lang.scala, the outline functionality is now built into vscode so the plugin we previously used is no longer needed. Let's close this as fixed.

gabro commented 6 years ago

@olafurpg The original issue was about the lack of instructions for manual, which is still the case. One has to install scala-lang.scala manually in order for the metals extension to work in development. Anywyay, I suspect those instructions will be removed/rewritten soon, so I'm ok with keeping this closed

olafurpg commented 6 years ago

Aah, you are right. Reopened, I will open a PR soon updating docs.