search

scalameta / metals

Scala language server with rich IDE features 🚀
https://scalameta.org/metals/
Apache License 2.0
2.1k stars 332 forks source link

javapc's HoverTermSuite fails on JDK 21 #5318

Open SethTisue opened 1 year ago

SethTisue commented 1 year ago

this came up in the Scala 2 community build:

-public interface java.util.List<E> extends java.util.SequencedCollection<E>
+public interface java.util.List<E> extends java.util.Collection<E>

https://scala-ci.typesafe.com/job/scala-2.13.x-jdk21-integrate-community-build/32/artifact/logs/metals-build.log

ckipp01 commented 1 year ago

Thanks for the report @SethTisue, it looks like we don't account for differences in the JDK versions in the suite. It should be a fairly quick fix.

EDIT: Just adding a note in here to say that I haven't forgotten about this, just cs doesn't have any 21 versions yet, and that's what I use to get my Java. So as soon as that appears I'll look further at this.

SethTisue commented 1 year ago

21's out and available

ckipp01 commented 1 year ago

21's out and available

Looks like @tgodzik started the work on https://github.com/scalameta/metals/pull/5758