Closed ckipp01 closed 10 months ago
Thanks for reporting! This seems to work correctly for me in VS Code, it shouldn't be related to the build server at all. Unless the issue shows up only with multiple folders? @kasiaMarek could you confirm if this is an issue and whether we should hold off with th release?
If you want exact reproduction steps (maybe this will help):
JAVA_HOME
set to 11killall java
just to ensure no Bloop is runningmake setup-ide
to ensure the .bsp
and .metals
get created where they shouldYes, looking into it. We should hold the release until this is resolved and I expect this to be connected to the changes around didChangeConfiguration
not the build server. Thanks for the reporting ❤️
Hey @ckipp01, sorry to bother, but just out of curiosity, you've mentioned that:
Then after a bit I see the colors change since the tokens are returned and mess all the highlighting up
Regarding this, is there a problem with semantic tokens on the Metals side, or is it rather about something to do with Neovim or its theme? Just wondering if there's an issue to be reported here. :+1:
Regarding this, is there a problem with semantic tokens on the Metals side, or is it rather about something to do with Neovim or its theme? Just wondering if there's an issue to be reported here. 👍
In my experience when things aren't fully compiling at times the highlighting that Metals sends back is less than optimal (see the image I have attached above). I also think the treesitter highlighting in Neovim is quite good, so I prefer to use that since I'm also a maintainer over there and like to spot when things look off.
We should probably not send semantic tokens if the project is not compiling to large extent :thinking: but that might be hard to figure out a heuristic
Describe the bug
I think this might actually be due to a bunch of BSP errors happening that I reported in https://github.com/VirtusLab/scala-cli/issues/2412, but I've noticed that in this situation even though
"enableSemanticHighlighting": false
has been turned on, it's still returned. For example here is some of the LSP logs showing this with some things in between redacted.Notice how metals does respond with the
textDocument/semantcTokens/full
when it shouldn'tExpected behavior
If this is turned off by the client, it should never be sent.
Operating system
macOS
Editor/Extension
Nvim (nvim-metals)
Version of Metals
1.0.1+103-cc897ef4-SNAPSHOT
Extra context or search terms
No response