Release v1.0.1 breaks listener notifications for skipped suites - Githubissues

scalameta / munit

Scala testing library with actionable errors and extensible APIs

https://scalameta.org/munit

Apache License 2.0

429 stars 90 forks source link

Release v1.0.1 breaks listener notifications for skipped suites #813

Open nikita-tkachenko-datadog opened 2 months ago

nikita-tkachenko-datadog commented 2 months ago

The way notifications work is changed in this PR.

In versions up to and including v1.0.0 a custom RunListener implementation receives the following notifications when a suite is skipped:

org.junit.runner.notification.RunListener#testSuiteStarted
org.junit.runner.notification.RunListener#testIgnored
org.junit.runner.notification.RunListener#testSuiteFinished

With the PR referenced above only the org.junit.runner.notification.RunListener#testIgnored notification is fired for such suites.

tgodzik commented 2 months ago

Thanks for reporting! We should probably rework this to still send notification, but not print them. :thinking:

I will not have time to work on that anytime soon, so any contributions would be welcome.