search

scalameta / sbt-native-image

Plugin to generate native-image binaries with sbt
251 stars 22 forks source link

Support Java 11 based graalvm distributions #7

Closed krzemin closed 3 years ago

krzemin commented 4 years ago

There are graalvm distributions based on Java 8 (graalvm) or Java 11 (graalvm-java11):

...
graalvm:19.0.0
graalvm:19.0.2
graalvm:19.1.0
graalvm:19.1.1
graalvm:19.2.0
graalvm:19.2.0-1
graalvm:19.2.1
graalvm:19.3.0
graalvm:19.3.1
graalvm:19.3.2
graalvm:20.0.0
graalvm:20.1.0
graalvm-java11:19.3.0
graalvm-java11:19.3.1
graalvm-java11:19.3.2
graalvm-java11:20.0.0
graalvm-java11:20.1.0

So far the plugin hardcodes graalvm, but it would be nice if we could select Java 11 based version too.

Btw, thanks for nice plugin 👍

olafurpg commented 3 years ago

Thank you for reporting! I debated whether I should introduce a nativeImageJvm := "graalvm-java11" setting key. It's currently possible to work around this with the settings

    nativeImageCommand := {
      val svmVersion = nativeImageVersion.value
      List(
        nativeImageCoursier.value.absolutePath,
        "launch",
        "--jvm",
        s"graalvm-java11:$svmVersion",
        s"org.graalvm.nativeimage:svm-driver:$svmVersion",
        "--"
      )
    }

I'm happy to merge a PR making this part configurable 👍

krzemin commented 3 years ago

Awesome, thank you 🎉