search

scalameta / sbt-native-image

Plugin to generate native-image binaries with sbt
248 stars 22 forks source link

Give some love to the project #70

Open guizmaii opened 1 year ago

guizmaii commented 1 year ago

The tests are failing, but as they're also failing on the main branch, I'm unsure if I broke something. I tried to fixed the tests but I don't understand why the agent-test tests are failing

Cc @ckipp01 @olafurpg

guizmaii commented 1 year ago

Hey @ckipp01,

Thanks for your comment and initial review :)

If this is something you use, would you be interested in joining the group of maintainers for it?

I'm already maintaining/helping to maintain too many things but I'll use this plugin, so yes I'm interested in joining 🙂

ckipp01 commented 1 year ago

Ah annoying, so I tried to bump to 22.3.0 since I was having issues locally with that, but then I also see that the way it's installed in CI now is with Jabba, which we should just ditch and do what you did with the setup-graal. I was also trying to get things locally to pass on my machine, but things fails since I don't have the NATIVE_IMAGE_COMMAND set locally. I don't actually like that you have to set that manually. So here is what I propose.

I might actually take the CI changes PR that you made and put that on top of this just to ensure we can use a newer Graal version in CI. I might also change up the tests to not fail if NATIVE_IMAGE_COMMAND isn't found because locally they still work fine with out it. This will hopefully get us a bit further. I'm honestly fine with merging in if everything isn't 🟢 but I'd still like to get the ubuntu stuff working. I figure we can slowly just keep tackling small things.

Also I hope it's ok that I'm just adding commits on top of this.

guizmaii commented 1 year ago

Also I hope it's ok that I'm just adding commits on top of this

It's completely fine. Thanks for your help, Chris! ❤️

I'm honestly fine with merging in if everything isn't 🟢 but I'd still like to get the ubuntu stuff working. I figure we can slowly just keep tackling small things.

Agreed. I'd like to see everything green but we need to make small steps here.

I might actually take the CI changes PR that you made and put that on top of this just to ensure we can use a newer Graal version in CI. I might also change up the tests to not fail if NATIVE_IMAGE_COMMAND isn't found because locally they still work fine with out it. This will hopefully get us a bit further.

Go for it 🙂 Tell me if you need help. I'm always available on Discord if you have questions.

ckipp01 commented 11 months ago

I haven't forgotten about this @guizmaii, just been swamped with other stuff. I will get back to it soon.