search

scalanlp / breeze

Breeze is/was a numerical processing library for Scala.
https://www.scalanlp.org
Apache License 2.0
3.45k stars 692 forks source link

bump to Scala 2.13.1 (was 2.13.0) #769

Closed SethTisue closed 4 years ago

SethTisue commented 4 years ago

the 2.11 job is failing — surely that doesn't have to do with the changes in this PR?

the 2.13 job is failing with errors I'm also seeing in the Scala community build — any insight?

SethTisue commented 4 years ago

ping, any maintainers around?

dlwh commented 4 years ago

sorry, I'll try to get to this this week

On Mon, Jan 27, 2020 at 5:03 PM Seth Tisue notifications@github.com wrote:

ping, any maintainers around?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/scalanlp/breeze/pull/769?email_source=notifications&email_token=AAACLIMGGXKRSC5UYRWXIV3Q7577RA5CNFSM4KF4G7G2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKBVAJQ#issuecomment-579031078, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAACLIOEV6GWLHQW4DR7PF3Q7577RANCNFSM4KF4G7GQ .

SethTisue commented 4 years ago

thanks!

I should probably clarify my intention here: anytime a project is unable to upgrade to a new Scala version, we are concerned that a regression in Scala might be at fault

since this isn't my codebase, I can't judge the actual likelihood of that myself. but you'll likely want or need to upgrade at some point anyway, so you'll probably need to dig into this eventually regardless.

dlwh commented 4 years ago

I see. I think i broke something in my 2.13 build prior to your PR and haven't gotten around to fixing it.

I was only building for 2.12 locally, and IIRC when I saw it was another collection migration thing I just didn't want to deal with it at the time. (It's not a bug in 2.13, just the API breakage for implementors of collections and needing to have two versions of a class to support both 2.12 and 2.13)

On Mon, Jan 27, 2020 at 6:02 PM Seth Tisue notifications@github.com wrote:

thanks!

I should probably clarify my intention here: anytime a project is unable to upgrade to a new Scala version, we are concerned that a regression in Scala might be at fault

since this isn't my codebase, I can't judge the actual likelihood of that myself. but you'll likely want or need to upgrade at some point anyway, so you'll probably need to dig into this eventually regardless.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/scalanlp/breeze/pull/769?email_source=notifications&email_token=AAACLIKTT7AKKTC6SNSOGX3Q76GZVA5CNFSM4KF4G7G2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKBYGZQ#issuecomment-579044198, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAACLIM2BSGYHNDEEBCNIC3Q76GZVANCNFSM4KF4G7GQ .

dlwh commented 4 years ago

thank you!