search

scalanlp / breeze

Breeze is/was a numerical processing library for Scala.
https://www.scalanlp.org
Apache License 2.0
3.45k stars 693 forks source link

Issue 779/outer product with sparse vectors #780

Closed bluesheeptoken closed 4 years ago

bluesheeptoken commented 4 years ago

First version of the implementation of outer product between DenseVector and Transposed SparseVector. Should close #779

I am very welcome to reviews, I was not sure in which trait I should put the operations implementations.

I tried to mutualize these 2 operations implementations with macro, without success.

bluesheeptoken commented 4 years ago

Hey @dlwh, I submitted this PR for outer product.

I have seen several issues I might have time to handle, however I prefer having a review on this PR before starting another one. To make sure I do not have already wrong habits.

Thanks !

bluesheeptoken commented 4 years ago

Appreciate it! I'm pretty sure there's a bug? Could you test for num-non-zero >2 and length > 2?

My pleasure !

I completed the tests, which bug did you have in mind ?

dlwh commented 4 years ago

thanks again!