Adjusted values should be used in convergence update in FirstOrderMinimizer

scalanlp / breeze

Breeze is/was a numerical processing library for Scala.

https://www.scalanlp.org

Apache License 2.0

3.45k stars 693 forks source link

Closed shvimas closed 4 years ago

shvimas commented 4 years ago

As per https://groups.google.com/forum/#!topic/scala-breeze/YapqCs6222w adjValue and adjGrad should be used in convergence check in FirstOrderMinimizer::infiniteIterations

shvimas commented 4 years ago

The way I see it updateHistory should also use the adjusted values, do you agree?