scalanlp / breeze

Breeze is a numerical processing library for Scala.
www.scalanlp.org
Apache License 2.0
3.44k stars 691 forks source link

WishartTest doesn't compile #841

Closed SethTisue closed 2 years ago

SethTisue commented 2 years ago

on master, on Scala 2.13.8:

[error] /Users/tisue/breeze/math/src/test/scala/breeze/stats/distributions/WishartTest.scala:25:19: could not find implicit value for parameter impl: breeze.stats.mean.Impl[IndexedSeq[breeze.linalg.DenseMatrix[Double]],VR]
[error]       val m = mean(sample)
[error]                   ^

this came up in the Scala 2.13 community build, and I'm also able to reproduce it locally in a fresh checkout

I don't understand why #839 isn't showing the same failure?!

SethTisue commented 2 years ago

I don't understand why https://github.com/scalanlp/breeze/pull/839 isn't showing the same failure?!

perhaps because .github/workflows/scala.yml does sbt test instead of sbt +test?

dlwh commented 2 years ago

Sorry! That's probably why. Will try to get to it this weekend

On Thu, Feb 24, 2022, 7:43 PM Seth Tisue @.***> wrote:

I don't understand why #839 https://github.com/scalanlp/breeze/pull/839 isn't showing the same failure?!

perhaps because .github/workflows/scala.yml does sbt test instead of sbt +test?

— Reply to this email directly, view it on GitHub https://github.com/scalanlp/breeze/issues/841#issuecomment-1050493086, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAACLINJUGYIY27BV4CUVJLU433GLANCNFSM5PJFDLXQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you are subscribed to this thread.Message ID: @.***>

SethTisue commented 2 years ago

scala/community-build@8da9bde2 :+1: