search

scalanlp / breeze

Breeze is a numerical processing library for Scala.
www.scalanlp.org
Apache License 2.0
3.44k stars 691 forks source link

Compile benchmark directory #859

Closed bwignall closed 1 month ago

bwignall commented 1 month ago

The benchmark directory was not compiling on a fresh checkout. Some of this was because of changes to the Google Caliper dependency, some to Breeze APIs in the "root" directories, some other.

The benchmark directory now compiles cleanly, locally.

bwignall commented 1 month ago

I must admit that I haven't tried running the benchmarks themselves, so I don't have an immediate sense for how to run a fast version. How about the following? I add a CI step in the existing config, to add a benchmark / compile checking step, and I save the updated runs for a separate PR?

dlwh commented 1 month ago

sure that's great. I'm gonna merge this as-is if you want to follow up with more PR's, please lmk!