search

scalapb / scalapb-grpcweb

Grpcweb support for ScalaPB (Experimental!)
42 stars 12 forks source link

Question about server-side grpc-web support #181

Open visortelle opened 2 years ago

visortelle commented 2 years ago

Hello.

What about built-in server-side grpc-web support to eliminate additional proxies like Envoy?

Like it's done here: https://docs.rs/tonic-web/latest/tonic_web/

Is there any chance that it may be done in the scope of the ScalaPB project or its better to wait for news on this topic from https://github.com/grpc/grpc-java ?

Thank you.

steinybot commented 2 months ago

One reason I want this is to greatly simplify my e2e tests. It would be nice to have a single test that could run on both platforms.

thesamet commented 2 months ago

It would be nice if there was a Java implementation we could use. I'm not sure what it takes to write and maintain an implementation of a simple grpc-web server that is relatively simple (for tests only) though I am happy to accept a PR for that.

steinybot commented 2 months ago

Where do the shaded versions of io.grpc come from? I see them being added to grpcweb/target/scala-2.12/classes/io/grpc but how do they get there?

thesamet commented 2 months ago

I don't believe there is any shading. But maybe you mean the fake ones created in this project? The sources are under grpcweb/src/main/scala/io/grpc/

steinybot commented 2 months ago

Thanks. For some reason I thought there was more to it than that.