search

scalapb / zio-grpc

ScalaPB meets ZIO: write purely functional gRPC services and clients using ZIO
Apache License 2.0
257 stars 81 forks source link

Only buffer stream if queue size is positive #578

Closed ghostdogpr closed 7 months ago

ghostdogpr commented 7 months ago

See discussion here: https://github.com/scalapb/zio-grpc/pull/514#issuecomment-1797901101

This change allows setting a queue size of 0 or -1 to prevent the buffering and preserve the chunk structure, which is desirable when working with many small messages.

thesamet commented 7 months ago

Thanks @ghostdogpr ! Do you mind sending a PR that describes this setting in this doc: https://github.com/scalapb/zio-grpc/blob/master/docs/backpressure.md and CHANGELOG.md?

ghostdogpr commented 7 months ago

Will do!