scalapuzzlers / scalapuzzlers.github.com

Github Pages behind scalapuzzlers.com
www.scalapuzzlers.com
161 stars 53 forks source link

Get the book #117

Closed nermin closed 9 years ago

nermin commented 9 years ago

Per email discussion.

demobox commented 9 years ago

Thanks! Do you have a screenshot of the rendered result which you could attach..?

nermin commented 9 years ago

image

demobox commented 9 years ago

Thanks for the screenshot. Nice! Just a couple of comments:

image

demobox commented 9 years ago

Full-screen screenshots of how 653d8b5 renders for me:

Chrome: image

Firefox: image

IE: image

nermin commented 9 years ago

Do you think it would be easy to adjust the spacing so that the "Get the book" block is the same height > as the other one at fullscreen?

I did try, but couldn't get to line up perfectly. Then, I also realized that the height of those boxes depends on the browser window size (for example, try resizing your browser to half size). What do you think about making that yellow color the same as background color?

nermin commented 9 years ago

How about changing the text to "In-depth explanations, discussion, workarounds and more!" or so? I like that.

demobox commented 9 years ago

Then, I also realized that the height of those boxes depends on the browser window size (for example, try resizing your browser to half size)

That's actually what I see normally ;-) But I think it's fair enough to assume that most users will have window sizes/screen resolutions where the left-hand box does not wrap, so if it lines up in fullscreen view, I'd say that's OK

What does the current version look like in your browsers if the browser window is fullscreen?

demobox commented 9 years ago

@nermin: Ping..? ;-)

nermin commented 9 years ago

The screenshot I have attached is with the browser fullscreen.

demobox commented 9 years ago

The screenshot I have attached is with the browser fullscreen.

That was the original PR, I guess...could you try again after a git pull? I'm just trying to see whether the two boxes now line up (more or less) for you too, especially on Safari.

Thanks!

nermin commented 9 years ago

Sure, here is full size: image

nermin commented 9 years ago

Not full size: image

nermin commented 9 years ago

I think we should get rid of that darker yellow color.

demobox commented 9 years ago

Sure, here is full size:

Rats ;-) Let's try without the background, indeed.

demobox commented 9 years ago

Try now:

image

Certainly better than the two unequal boxes, but I'd prefer this if we could implement it:

image

What do you think?

PS: If we're OK with the current version (i.e. without a background) I'd suggest we commit it just to have something up there. We can always improve later...

demobox commented 9 years ago

Squashed what we have so far and merged to master as 2bcd997. We can always revisit if desired.

Thanks, @nermin!

nermin commented 9 years ago

Thank you Andrew. The site is overdue for redesign anyway.