search

scalapuzzlers / scalapuzzlers.github.com

Github Pages behind scalapuzzlers.com
www.scalapuzzlers.com
161 stars 53 forks source link

refactor + scalakata api #79

Closed MasseGuillaume closed 10 years ago

demobox commented 11 years ago

Hi @MasseGuillaume

This is a rather large commit that cannot be merged, according to GitHub. Could you kindly first explain what the key parts of the change are, perhaps based on submitting a "dummy" puzzler with Kata enabled?

Thanks!

demobox commented 11 years ago

Oh, and could you also squash down the commits so that each one refers to a distinct functional change that can be reviewed in one go? Right now there are lots of what look like "fix" commits that make understanding the logic of the change harder for a reviewer.

Thanks!

demobox commented 10 years ago

Closing this out for now. Hopefully we can revisit this sometime soon. Thanks for all your work, @MasseGuillaume!