scalapuzzlers / scalapuzzlers.github.com

Github Pages behind scalapuzzlers.com
www.scalapuzzlers.com
161 stars 53 forks source link

40 - set the record straight #82

Closed edofic closed 11 years ago

demobox commented 11 years ago

Thanks, @edofic! I like the setup. A couple of quick housekeeping comments:

  1. Could you rename the file pzzlr-set-the-record-straight.html? That way, we won't run into possible merge conflicts
  2. There are currently only three sample answers - the "standard" for puzzlers is to have four. Could you add one?

Also, how about the following variant that "hides" the effect a bit?

List("1", "2").toSet() + "3"

?

edofic commented 11 years ago
  1. done
  2. there are four already. compile error, runtime error, Set(1) and false.

I like the List one better too, so I changed it

demobox commented 11 years ago

there are four already. compile error, runtime error, Set(1) and false.

Doh! Thanks, I missed that ;-)

nermin commented 11 years ago

Just had couple of minor suggestions, but I like this one!

demobox commented 11 years ago

@nermin Thanks for the review!

demobox commented 11 years ago

@edofic Thanks for the cleanup! One final request: could you squash all your commits into one? Then we can merge ;-)

edofic commented 11 years ago

@demobox done

demobox commented 11 years ago

See http://scalapuzzlers.com/#pzzlr-040. Thanks, @edofic!