search

scalar-labs / scalar-jepsen

Jepsen tests for ScalarDB and ScalarDL
45 stars 6 forks source link

Should return info type when UnknownTransactionStatusException #84

Closed brfrn169 closed 2 years ago

brfrn169 commented 2 years ago

When UnknownTransactionStatusException is thrown, we are not sure the transaction is committed or not. In that case, we should return :info type. This PR fixes it. Please take a look!

brfrn169 commented 2 years ago

I thought we were returning info in such a case. I feel returning fail for this would cause more inconsistent results, but it really didn't?

Yes, I think so, too. I'm not sure why returning fail when UnknownTransactionStatusException didn't cause inconsistent results so far.

@yito88 What do you think?