search

scalar / openapi-parser

Modern OpenAPI parser written in TypeScript
MIT License
26 stars 7 forks source link

chore: loosen the types #117

Closed hanspagel closed 1 month ago

hanspagel commented 1 month ago

We want to type the specification we get from the user so we have an autocomplete in the IDE. But we also have to expect that the user doesn’t adhere to the OpenAPI specification, so any attribute can be passed on any level.

This isn’t as beautiful as it could be, but works for now. 😬 I’ll go over the types again ASAP.

changeset-bot[bot] commented 1 month ago

🦋 Changeset detected

Latest commit: cc3b85039e13dbfbaee1a90067f37454f46d150d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ---------------------- | ----- | | @scalar/openapi-parser | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

relativeci[bot] commented 1 month ago

#71 Bundle Size — 114.09KiB (0%).

cc3b850(current) vs 05dbbc4 main#68(baseline)

Bundle metrics  no changes
                 Current
#71		      Baseline
#68
No change  Initial JS 114.09KiB 114.09KiB
No change  Initial CSS 0B 0B
No change  Cache Invalidation 0% 0%
No change  Chunks 44 44
No change  Assets 44 44
No change  Modules 44 44
No change  Duplicate Modules 0 0
No change  Duplicate Code 0% 0%
No change  Packages 0 0
No change  Duplicate Packages 0 0

Bundle size by type  no changes
|            |       Current
[#71](https://app.relative-ci.com/projects/hXQ54UQKluDUZAKvpt9b/jobs/71-waGQtik3lnnR5Wpwlend?utm_source=github&utm_medium=pr-report "View bundle analysis report") |      Baseline
[#68](https://app.relative-ci.com/projects/hXQ54UQKluDUZAKvpt9b/jobs/68-IwT5y0NWGF7mU95qi3m8?utm_source=github&utm_medium=pr-report "View baseline bundle analysis report") | |:--|--:|--:| | No change  [JS](https://app.relative-ci.com/projects/hXQ54UQKluDUZAKvpt9b/jobs/71-waGQtik3lnnR5Wpwlend/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-1_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-0%22%7D "View JS assets") | `114.09KiB` | `114.09KiB` |

Bundle analysis report Branch fix/types Project dashboard

hanspagel commented 1 month ago

I don’t like this solution. Need to think about what we really want.