scalar / openapi-parser

Modern OpenAPI parser written in TypeScript
MIT License
34 stars 1 forks source link

refactor: resolve should resolve #92

Closed hanspagel closed 3 months ago

hanspagel commented 3 months ago

Currently, we have the resolve() utility, which is actually validating and resolving all references. I think that was a mistake.

This PR removes validation from the resolve utility.

I’ll probably add a few more changes to it, to align the output of all the utilities more.

changeset-bot[bot] commented 3 months ago

πŸ¦‹ Changeset detected

Latest commit: 6f006dae17841ada11b2348ff6c577c2e09eef7f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages | Name | Type | | ---------------------- | ----- | | @scalar/openapi-parser | Patch | | demo | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

relativeci[bot] commented 3 months ago

#33 Bundle Size β€” 480.46KiB (-0.03%).

6f006da(current) vs 286ce7c main#32(baseline)

Bundle metrics  Change 2 changes Improvement 1 improvement
                 Current
#33
     Baseline
#32
Improvement  Initial JS 480.46KiB(-0.03%) 480.61KiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 100% 0%
No change  Chunks 1 1
No change  Assets 1 1
No change  Modules 306 306
No change  Duplicate Modules 0 0
No change  Duplicate Code 0% 0%
No change  Packages 10 10
No change  Duplicate Packages 0 0

Bundle size by type  Change 1 change Improvement 1 improvement
|            |       Current
[#33](https://app.relative-ci.com/projects/hXQ54UQKluDUZAKvpt9b/jobs/33-LgUUfzdkBTtz6DXEAwsg?utm_source=github&utm_medium=pr-report "View bundle analysis report") |      Baseline
[#32](https://app.relative-ci.com/projects/hXQ54UQKluDUZAKvpt9b/jobs/32-Q9cITlPpDTohdRfVMwNp?utm_source=github&utm_medium=pr-report "View baseline bundle analysis report") | |:--|--:|--:| | Improvement  [JS](https://app.relative-ci.com/projects/hXQ54UQKluDUZAKvpt9b/jobs/33-LgUUfzdkBTtz6DXEAwsg/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-1_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-0%22%7D "View JS assets") | `480.46KiB` (`-0.03%`) | `480.61KiB` |

Bundle analysis report Branch refactor/resolve-should-resolve Project dashboard

hanspagel commented 3 months ago

Let’s just get this in and take it from there. :)