search

scalastyle / scalastyle-sbt-plugin

scalastyle-sbt-plugin
Apache License 2.0
139 stars 52 forks source link

Fix scalastyleConfig in multi-project builds #45

Closed gcpagano closed 7 years ago

gcpagano commented 9 years ago

This is to get the plugin to properly work with multi-projects build. This PR should resolve #42 and resolve #44 It's using the auto-plugins feature introduced in 0.13.5, the downside is that it will only be compatible with sbt 0.13.5+

mhzajac commented 8 years ago

Will this ever be merged, or looked at? It works as best as I can tell, and fixed all of the issues I was having with my large multi-project builds.

ayoub-benali commented 8 years ago

What is the status if the PR ?

matthewfarwell commented 8 years ago

Sorry, I've been really busy. I may have some time this week or next, I'll look at it.

marekrogala commented 8 years ago

:+1: @matthewfarwell can you take a look?

filipesabella commented 8 years ago

Also having problems with this.

abhamjee commented 8 years ago

We too really need this.

kflorence commented 7 years ago

Is this project dead?

matthewfarwell commented 7 years ago

The master of the sbt plugin is now compatible with AutoPlugin. Can you try this and see if it works with your builds, or if there are other things that need to happen? I will look on my side. The PR that was used is #52. It should be available in 0.9.0-SNAPSHOT.

gcpagano commented 7 years ago

I've updated the PR, rebasing it on the current master. The test for multi-projects build works for me. The travis build is failing because of the before_install section currently in master, and it doesn't seem releated to this PR. Here is the error:



This job is running on container-based infrastructure, which does not allow use of 'sudo', setuid, and setgid executables.

If you require sudo, add 'sudo: required' to your .travis.yml

The command "sudo hostname "$(hostname | cut -c1-63)"" failed and exited with 1 during .```
matthewfarwell commented 7 years ago

Cool. Thanks!