Feature: fail-on-warning option

scalastyle / scalastyle-sbt-plugin

scalastyle-sbt-plugin

Apache License 2.0

139 stars 52 forks source link

Closed andys8 closed 7 years ago

andys8 commented 7 years ago

Added parameter scalastyleFailOnWarning. If true, the scalastyle task fails if any messages at warning level are output. Default value is false.

Feature #58 requested by @zgraggen, PR suggested by @matthewfarwell.

Test case config/fail-on-warning added. scalastyleFailOnWarning is true and expects scalastyle execution to fail.
Analogue test-config/fail-on-warning
Case where the option is disabled is default and covered by other tests.

Closes #58 and #18

matthewfarwell commented 7 years ago

Great! I'll merge this if you do a rebase and squash. Thanks.

andys8 commented 7 years ago

@matthewfarwell Okay, I squashed the PR to a single commit. Squash merge should be a github feature. Could make sense to use it in the future :)

matthewfarwell commented 7 years ago

Great. Thanks!

zgraggen commented 7 years ago

@andys8 Thanks you for implementing this feature!

andys8 commented 7 years ago

You're welcome. Hopefully there will be a release soon 🤞