search

scalate / sbt-scalate-precompiler

:open_file_folder: Scalate Templates Precompiler
http://scalate.github.io/scalate/
MIT License
10 stars 4 forks source link

Does not work with SBT 1.2.3 #10

Closed ngocdaothanh closed 6 years ago

ngocdaothanh commented 6 years ago

I've created this very simple example project: https://github.com/xitrum-framework/sbt-scalate-precompiler-example

sbt-scalate-precompiler works when the project is set to use SBT 0.13.7.

But it doesn't work when the project is set to use SBT 1.2.3.

ngocdaothanh commented 6 years ago

Note: I'm using Mac 10.13.6.

ngocdaothanh commented 6 years ago

I've just checked on Ubuntu. sbt-scalate-precompiler does not work with SBT 1.2.3 either.

ngocdaothanh commented 6 years ago

I've just tried with SBT 1.1.0. It doesn't work either.

When I tried with SBT 1.0.0, there's error from SBT:

[error] sbt.internal.IncompatiblePluginsException: Binary incompatibility in plugins detected.
[error] Note that conflicts were resolved for some dependencies:
[error]     org.scala-lang.modules:scala-parser-combinators_2.12
[error]     org.slf4j:slf4j-api
[error]     org.scala-lang.modules:scala-xml_2.12
ngocdaothanh commented 6 years ago

Hi, is there any news about this issue?

seratch commented 6 years ago

I don’t have time to check until tomorrow. The following one is a working example. Checking it may be of help to you.

https://github.com/skinny-framework/skinny-framework/tree/master/skinny-blank-app

If I see any bugs in this sbt plugin, I will work on it.

ngocdaothanh commented 6 years ago

Thanks!

I see that the README doesn't mention scalateSettings at the section for build.sbt. After I add it, sbt-scalate-precompiler works as expected.

So please improve README to mention scalateSettings for build.sbt.

seratch commented 6 years ago

I got it. Will do. Thanks!

seratch commented 6 years ago

I've updated README to have scalateSettings in build.sbt by https://github.com/scalate/sbt-scalate-precompiler/commit/860b6faf2f50713e47738d534dcfec51d43c596c .

Thank you for your feedback. Let me close this issue.