search

scalatest / scalatest-maven-plugin

ScalaTest Maven Plugin
Apache License 2.0
34 stars 61 forks source link

Use same JVM that maven is using. #43

Closed cstroe closed 5 years ago

cstroe commented 7 years ago

Use the java executable that Maven ran with. Inspired from the Surefire plugin's getEffectiveJvm minus the toolchain lookup.

Fixes #6, #14 and #26

cstroe commented 7 years ago

@gcberger I'd love to have this be included in the upcoming version 2.0.0!

cstroe commented 7 years ago

@gcberger Any chance in merging this?

robsonpeixoto commented 7 years ago

@gcberger ping

andrewdibiasio6 commented 7 years ago

I echo this @gcberger "Any chance in merging this?"

gcberger commented 7 years ago

Hi Bill -

Forwarding this, in case you don't get these.

George

On Wed, Oct 4, 2017 at 10:15 AM, andrewdibiasio6 - notifications@github.com github.ecto.b28dfc987e.notifications#reply@reply.github.com wrote:

I echo this @gcberger https://github.com/gcberger "Any chance in merging this?"

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/scalatest/scalatest-maven-plugin/pull/43#issuecomment-334226076, or mute the thread https://github.com/notifications/unsubscribe-auth/AD52beyKYbEIbDqdkHwjt_yddLDvfYU1ks5so71AgaJpZM4Nl8y- .

Mats-SX commented 6 years ago

Ping. We'd love to have this.

martin-g commented 6 years ago

I think a better solution would be to make scalatest-maven-plugin toolchains aware (https://github.com/scalatest/scalatest-maven-plugin/issues/58). I don't think this PR would solve the issue described at #58 .

cstroe commented 6 years ago

I think the delay is that I have to sign the CLA, which has to be approved by my current employer: https://github.com/scalatest/scalatest-maven-plugin/pull/37#issuecomment-427604420

Also, yes, we should definitely make this plugin Toolchain aware, but that could be subsequent work.

martin-g commented 6 years ago

I can do the work to use ToolchainManager in the coming days if there is a chance that it will be ever used. This PR is one year and a half old and it seems there is no much interest from the maintainers.

cstroe commented 6 years ago

Some options to solve maintainership absence:

  1. The current maintainers can add an active member of the OSS community as a committer/maintainer to this repository and have them be the approver of commits.
  2. The community can fork this repo into another org that can be better maintained.
  3. Something else I couldn't think of...?

I think the first option is better as it avoids fragmentation of the community.

cstroe commented 6 years ago

@gcberger @bvenners , I have signed and emailed the CLA.

bvenners commented 6 years ago

@cstroe Thanks very much! I got the CLA. We'll get this merged and released as soon as we can.

stefano-xy commented 5 years ago

@bvenners , are the administrative problems solved? I would also like to have this merged. Thanks.

manuzhang commented 5 years ago

Any progress here ?

bvenners commented 5 years ago

Sorry for the delay. I'll get it going.

rondefreitas commented 5 years ago

Thanks @bvenners . Looking forward to seeing this out there. There's a couple of other PRs I've been waiting on seeing merged (and I'm sure others). No pressure though and thanks for circling back to look at this project :)

manuzhang commented 5 years ago

@bvenners @katrinsharp Thanks, is there a plan to make a new release with this fix ?

katrinsharp commented 5 years ago

@manuzhang I'll discuss with @bvenners and let you know. Please stay tuned.

manuzhang commented 5 years ago

@katrinsharp @bvenners Thanks. Any plan to make a new release for this fix ?

katrinsharp commented 5 years ago

@manuzhang my bad I'm slow on some other open PRs to review. I'll try to fit all open ones in next couple of weeks.

chetanmeh commented 4 years ago

@katrinsharp Any plan to make a new release for this fix ?

katrinsharp commented 4 years ago

@chetanmeh My apologies! I'm going to handle this as we speak.

chetanmeh commented 4 years ago

Thanks @katrinsharp for responding and looking into this

katrinsharp commented 4 years ago

Update: I'm handling couple of different PRs and then release - several days.

amirhadadi commented 4 years ago

@katrinsharp can you please release a version with this fix?

qsarahd commented 4 years ago

Joining the requests. @katrinsharp, can you please release a version with the fix?

katrinsharp commented 4 years ago

It was released. There is an issue to sync up with Maven central - I've put a request to get it sorted, meanwhile you can try the new version by adding this to your PM:

<pluginRepositories>
  <pluginRepository>
    <id>releases</id>
    <url>https://repo1.maven.org/maven2</url>
  </pluginRepository>
</pluginRepositories>

I'll add a new comment here letting everyone know that it was synced up with Maven central.

Update: you don't need to add thew above code, the jar did make its way into maven central, it is just https://mvnrepository.com/artifact/org.scalatest/scalatest-maven-plugin doesn't reflect that. I'm on it.

And it is on Maven central now.