search

scalatest / scalatest-maven-plugin

ScalaTest Maven Plugin
Apache License 2.0
34 stars 61 forks source link

Add verify stage #60

Open nab0310 opened 5 years ago

nab0310 commented 5 years ago

This Pull Request is an extension of https://github.com/scalatest/scalatest-maven-plugin/issues/59, adding a verify stage would help people who use docker to be able to use the scalatest-maven-plugin because it allows the post-integration test to run.

This is just a rough outline of what I think could be done. Obviously the file writing system is very crude but it was just my first draft. The Surefire plugin features a FailsafeSummaryXmlUtils class that provides utilities for file writing and reading that would provide a good solution to this problem.

katrinsharp commented 4 years ago

It's been sometime, so just wanted to see if it is still relevant.

plinlor commented 4 years ago

@cla-bot[bot] check

cla-bot[bot] commented 4 years ago

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: nb051436. This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails
cla-bot[bot] commented 4 years ago

The cla-bot has been summoned, and re-checked this pull request!

rondefreitas commented 3 years ago

I'm running into a similar issue with docker tests. It would be useful to have this functionality

cheeseng commented 2 years ago

@nab0310 Really sorry for getting to this so late, I think this enhancement will be useful, though still in draft (it seems like the exception is always thrown in verify stage?), would you mind to sign the CLA?

Thanks.

cheeseng commented 2 years ago

@cla-bot[bot] check

cla-bot[bot] commented 2 years ago

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: nb051436. This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails
cla-bot[bot] commented 2 years ago

The cla-bot has been summoned, and re-checked this pull request!

cheeseng commented 2 years ago

Hi @nab0310 , we require contributors to sign our Contributor License Agreement, and we don't have yours on file. In order for us to review and merge your code, please access https://www.artima.com/cla/choose-type to sign our Contributor License Agreement. Your effort is highly appreciated. Thank you.