search

scalatest / scalatest-maven-plugin

ScalaTest Maven Plugin
Apache License 2.0
34 stars 61 forks source link

Disabling Failsafe doesn't appear to be necessary #62

Open jeff303 opened 5 years ago

jeff303 commented 5 years ago

The documentation indicates that the Failsafe plugin should be disabled, by doing the following:

      <plugin>
        <groupId>org.apache.maven.plugins</groupId>
        <artifactId>maven-surefire-plugin</artifactId>
        <version>2.7</version>
        <configuration>
          <skipTests>true</skipTests>
        </configuration>
      </plugin>

This sets the -DskipTests parameter, which makes the plugin skip running its tests. I'm not entirely clear why this is required. I have tested without doing this and noticed no problems (although I also have no Java tests in this module, so the Failsafe plugin simply runs nothing).

Can anyone share more detail as to why this step is required?

cheeseng commented 2 years ago

@jeff303 Actually I just tried it and it seems to be working also, @bvenners can you recall what's the reason behind the recommendation to disable surefire?