search

scalatest / scalatest-maven-plugin

ScalaTest Maven Plugin
Apache License 2.0
34 stars 61 forks source link

Fixes #57 using un-modifyable lists & judicious synchronization #63

Closed chrisalbright closed 4 years ago

chrisalbright commented 5 years ago

Mostly just ensuring lists are un-modifyable. Added synchronization to the side-effect code which creates a directory if it doesn't exist. Not sure how to test this, but in the build that inspired this change, the warnings are gone, and all is well.

chrisalbright commented 5 years ago

Hi there... any thoughts on merging this?

rondefreitas commented 5 years ago

looks good to me. I'm not sure who has write access here. maybe @gcberger / @cheeseng ?

rondefreitas commented 5 years ago

@chrisalbright looks like you have a merge conflict, not sure if you saw that come up

chrisalbright commented 5 years ago

@rdefreitas thanks for the head's up. I don't recall seeing this when I opened the PR, but it should be ok now.

chrisalbright commented 5 years ago

Hello out there! Is anybody interested in this project any longer? @gcberger ? @cheeseng ? I think my PR is a good one, and there are some maven users out there that would probably appreciate it (at least one)

chrisalbright commented 4 years ago

@rdefreitas do you have any ideas on how I can help move this forward? Is this project abandoned?

bvenners commented 4 years ago

@chrisalbright not abandoned, just moving in a bit of slow motion. @katrinsharp has been working on it lately, and we should have a release soon.

chrisalbright commented 4 years ago

Hi, @bvenners and @katrinsharp - just checking in here. Any motion on this PR?

katrinsharp commented 4 years ago

@chrisalbright yes today/tomorrow.

katrinsharp commented 4 years ago

LGTM.