Closed veysiertekin closed 3 years ago
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: veysi.ertekin. This is most likely caused by a git client misconfiguration; please make sure to:
git config --list | grep email
git config --global user.email email@example.com
Hi @veysiertekin, we require contributors to sign our Contributor License Agreement, and we don't have yours on file. In order for us to review and merge your code, please access https://www.artima.com/cla/choose-type to sign our Contributor License Agreement. Your effort is highly appreciated. Thank you.
@cla-bot[bot] check
The cla-bot has been summoned, and re-checked this pull request!
Hi Veysi, thank you for submitting you PR. Please see my comment.
hi @katrinsharp , I have added a few new test cases for command lines without or partially have new lines.
Problem
Formatters sometime causes new lines in
pom.xml
files:This result in failures at java command execution:
Solution
This PR replaces platform-agnostic new line delimiters ("\r", "\n", "\r\n") in argLine & debugArgLine with ordinary spaces (" ") to allow multiline JVM argument lists.
Reference
maven-surefire-plugin
also have a fix for this:https://github.com/apache/maven-surefire/blob/eb48f1b59ca5ccf6954ef33ecab03dbaf93214cd/maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/DefaultForkConfiguration.java#L246-L249