Closed mvnural closed 9 years ago
I created a pull request against your branch that should fix the issue. However, It should be noted that the solution drastically increases the build time (since it has to download ScalaTion, compile, and publish it locally).
Just checked Travis CI, and it looks like the fix works. You should go ahead and accept the pull request. I'll hold off on incorporating the change into develop
, since it will be incorporated the next time you make a pull request from mvnural
against master
.
Thanks! This looks cool. I'll check it out and let you know.
Sent from my Nexus 5 On Apr 14, 2015 6:59 AM, "Michael Cotterell" notifications@github.com wrote:
Just checked Travis CI, and it looks like the fix works. You should go ahead and accept the pull request. I'll hold off on incorporating the change into develop, since it will be incorporated the next time you make a pull request from mvnural against master.
— Reply to this email directly or view it on GitHub https://github.com/scalation/analytics/issues/33#issuecomment-92768453.
What should we the correct way to add ScalaTion as a dependency? I do it on my computer via my IDE but the builds keep failing in Travis CI as ScalaTion is not recognized.
We need to find a way to do this. Any suggestions?