scalatutorials / scalatutorials.github.io

7 stars 4 forks source link

Code evaluation seems broken #6

Open michel-zedler opened 10 years ago

michel-zedler commented 10 years ago

Getting the following console output when evaluating any code on http://scalatutorials.com/tour/

"Uncaught TypeError: undefined is not a function kata.js:14 renderEval kata.js:14 (anonymous function) kata.js:26 (anonymous function) jquery.min.js:4 l jquery.min.js:4 c.fireWith jquery.min.js:4 i.(anonymous function) jquery.min.js:4 listener kata.js:31 socket.onmessage"

There is a 404 when loading http://scalatutorials.com/assets/themes/twitter/scalakata/webjars/jquery-2.0.3.min.map

Using Chrome Version 34.0.1847.131 m

sebnozzi commented 10 years ago

It also does not work for me. Besides Chrome issued a lot of errors on the console regarding cross-site scripting.

eranation commented 10 years ago

Thanks Sebastian, sadly it's a known issue, Codebrew.io changed their API (they did give me a heads up but I was just before finals) Will do it ASAP. If you have time and would like to help I would gladly give you commit rights and explain where you can fix it :)

On Fri, May 16, 2014 at 6:46 AM, Sebastian Nozzi notifications@github.comwrote:

It also does not work for me. Besides Chrome issued a lot of errors on the console regarding cross-site scripting.

— Reply to this email directly or view it on GitHubhttps://github.com/scalatutorials/scalatutorials.github.io/issues/6#issuecomment-43318922 .

sebnozzi commented 10 years ago

If you have time and would like to help I would gladly give you commit rights and explain where you can fix it :)

If it can be solved by somebody with no prior knowledge on the project go ahead! :-)

sebnozzi commented 10 years ago

I'm already taking a look at the problem; maybe I'll be able to solve it... if it is what I think, I might. Otherwise I'll let you know...

(Damn, if this was not JavaScript but was statically typed - it would be much easier to solve ;-)

sebnozzi commented 10 years ago

I fixed it :-) Pull request soon to arrive. Unless you let me check-in directly to your repo...

But now what I have is that printlns don't display any output... And none seems to come from the AJAX call. I'm confused... Did the codebrew.io guys remove this functionality?

sebnozzi commented 10 years ago

Sent pull request

eranation commented 10 years ago

Thanks Sebastian, merged and live! Much appreciated

On Fri, May 16, 2014 at 1:20 PM, Sebastian Nozzi notifications@github.comwrote:

Sent pull request

— Reply to this email directly or view it on GitHubhttps://github.com/scalatutorials/scalatutorials.github.io/issues/6#issuecomment-43356869 .

sebnozzi commented 10 years ago

You're welcome! There is still the problem with missing (Scala) console output (printlns not showing).

Shall I open an issue, or is it a codebrew.io problem?

eranation commented 10 years ago

I think it's a codebrew.io problem, println doesn't seem to work there as well... I'll ask Gui

On Fri, May 16, 2014 at 1:25 PM, Sebastian Nozzi notifications@github.comwrote:

You're welcome! There is still the problem with missing (Scala) console output (printlns not showing).

Shall I open an issue, or is it a codebrew.io problem?

— Reply to this email directly or view it on GitHubhttps://github.com/scalatutorials/scalatutorials.github.io/issues/6#issuecomment-43357356 .

sebnozzi commented 10 years ago

Also, note for example that some expressions return a value and others don't although they are semantically almost similar. Consider this:

var x = 1 + 2 //> 3
println(x)    
x = 3 * 4 
println(x)

Only the var x... got a value, but the assignment didn't... Maybe it's intentional, but looks confusing.

sebnozzi commented 10 years ago

It's also unfortunate that:

val selection = "One" //> One
selection match {
  case "One" => "You selected option one!"
  case "Two" => "You selected option two!"
  case _ => "You selected something else: "
}  

does not show the resulting value of the match, but this does:

val selection = "One" //> One
val foo = selection match { //> "You selected option one!"
  case "One" => "You selected option one!"
  case "Two" => "You selected option two!"
  case _ => "You selected something else: "
}  
eranation commented 10 years ago

Yes, I'll check with Gui On May 16, 2014 5:40 PM, "Sebastian Nozzi" notifications@github.com wrote:

It's also unfortunate that:

val selection = "One" //> Oneselection match { case "One" => "You selected option one!" case "Two" => "You selected option two!" case _ => "You selected something else: "}

does not show the resulting value of the match, but this does:

val selection = "One" //> Oneval foo = selection match { //> "You selected option one!" case "One" => "You selected option one!" case "Two" => "You selected option two!" case _ => "You selected something else: "}

— Reply to this email directly or view it on GitHubhttps://github.com/scalatutorials/scalatutorials.github.io/issues/6#issuecomment-43382558 .