Issue 72 - replace IO.successful with IO.sync

scalaz / scalaz-nio

Performant, purely-functional, low-level, and unopinionated wrapper around Java NIO functionality

Apache License 2.0

84 stars 29 forks source link

Issue 72 - replace IO.successful with IO.sync #73

Closed LGLO closed 5 years ago

LGLO commented 5 years ago

@ysusuk - please take a look at one test I've changed (original code fails with this change test). I hope it explains why we cannot use IO.succeed to wrap calls to mutable state. If you agree with these changes, tell me then I'll update other tests as well.

ysusuk commented 5 years ago

@LGLO yes, pls =)

LGLO commented 5 years ago

@ysusuk I decided to update only limit tests because otherwise I would obscure tests of others methods with testing possible flaw in position or limit implementation. Ready for review.