resolves scalaz/scalaz-nio#69 Turn all zero-argument `def` into `val`

scalaz / scalaz-nio

Performant, purely-functional, low-level, and unopinionated wrapper around Java NIO functionality

Apache License 2.0

84 stars 29 forks source link

resolves scalaz/scalaz-nio#69 Turn all zero-argument `def` into `val` #86

Closed mschuwalow closed 5 years ago

mschuwalow commented 5 years ago

Sorry for not getting back to you earlier.

As far as I am aware it should be fine to use val everywhere here as constructing an (Z)IO does not actually execute anything. The changes in the pr should just change when / how often the data structure is constructed.

jczuchnowski commented 5 years ago

I agree. It's just a description of operation. It's fine to make a val from it.

ysusuk commented 5 years ago

@mschuwalow and @jczuchnowski, true! i'm sorry guys, i was confused that effect will be always the same, but since it contains a reference its all good!