search

scalda / Foolcraft_3

FoolCraft 3 is a follow up to the original FoolCraft, it's for Minecraft 1.12.2, and is aimed at having as much fun as freakin' possible, while maintaining a progressive Minecraft experience. It is the pack used by the official FoolCraft server found on YouTube and Twitch. Mods like Vein-miner, Inventory Pets & Chance Cubes makes your play through light weight and fun, whilst FoolCraft offers depth by having heavy tech mods such as Ender IO and Thermal Expansion, as well as magical mods such as Botania. FoolCraft guarantees you to have a great time! ##Minimal 6GB and maximum 8GB of ram allocated needed to run the pack smooth
20 stars 4 forks source link

Undiscoverable Memory Leak #329

Open jrhegd opened 6 years ago

jrhegd commented 6 years ago

Modpack Information

Issue Description

This modpack contains a memory leak that I am unable to determine the root source of. The game will constantly eat more memory (about 15-20MBs per second) until either my entire userspace gets sent to SWAP or if SWAP is disabled, the kernel kills the process. I have searched the process for Heap, Metaspace, and Stack space memory pools for leakage via VisualVM and have been unable to find anything.

Reproduce Steps

System Information:

os: Manjaro Linux x64 kernel: 4.17.19-1 MANJARO memory: 16057MiB total available java version: openjdk-1.8.0_u181 launcher: MultiMc 0.6.2 mmc settings:

Steps:

Additional Information

All The Mods 3 had a similar issue to this pack, where it had a memory leak. However, it was confirmed to be in the stack space as applying -Xss4G to launch arguments would crash the game instead of sending half of the userspace to SWAP. Doing the same to this pack just results in the game starting to stutter, but keep going while eating the entire system's memory pool.

nzminecraftDOTcom commented 6 years ago

Not the only pack with this issue. Possibly a java issue after a recent update. Stoneblock also has this problem, however server systems don't have the same issue.

nzminecraftDOTcom commented 6 years ago

Just to add: could also be due to changes in the MC launcher as one day I'm fine on 1.3.1 and the next I can't do anything 20 mins after starting the game. All on the same version. Other players on my server started having the same problems.

jrhegd commented 6 years ago

Not the only pack with this issue. Possibly a java issue after a recent update. Stoneblock also has this problem, however server systems don't have the same issue.

Just to add: could also be due to changes in the MC launcher as one day I'm fine on 1.3.1 and the next I can't do anything 20 mins after starting the game. All on the same version. Other players on my server started having the same problems.

By MC Launcher 1.3.1, do you mean the Mojang MC Launcher by the Twitch client? If so, I do doubt this as I am using MultiMC which according to the Minecraft launch process uses a modified version of the old java launcher. If in the rare chance that somehow a wrapper for a java execution command is the issue, it'd be odd that both a modified java launcher and the Mojang launcher's recent versions somehow cause the same issue. In terms of Java, it would be interesting to test. If this is the case, it is a bit strange that it supposedly works for both Oracle and OpenJDK. I'll see into testing some older versions of OpenJDK 8 and see if anything changes.

nzminecraftDOTcom commented 6 years ago

I believe no matter what launcher you use, it downloads files at the very beginning of loading to verify things and possibly do spot-updates on various game files. Could've very well happened with that.

jrhegd commented 6 years ago

Something anecdotal thus far as I have not finished testing, but it seems that the memory leak slows down a lot with the proprietary Java JDK 8 u121. As said, I am still testing with this and other versions to get a more clear picture and to eliminate variable changes, but using a stale version of java 8 may help to fix the issue.