scale-jobs / abfy.io

World's simplest A/B testing Library
3 stars 1 forks source link

Refactoring the code base for better Quality #8

Closed eyeamkd closed 1 month ago

eyeamkd commented 1 month ago
eyeamkd commented 1 month ago

Test Coverage Report

Lines: 97.36% (74/76) Statements: 97.61% (82/84) Functions: 91.66% (11/12) Branches: 93.1% (27/29)

eyeamkd commented 1 month ago

Test Coverage Report

Lines: 97.36% (74/76) Statements: 97.61% (82/84) Functions: 91.66% (11/12) Branches: 93.1% (27/29)

eyeamkd commented 1 month ago

Test Coverage Report

Lines: 97.36% (74/76) Statements: 97.61% (82/84) Functions: 91.66% (11/12) Branches: 93.1% (27/29)

eyeamkd commented 1 month ago

Test Coverage Report

Lines: 97.36% (74/76) Statements: 97.61% (82/84) Functions: 91.66% (11/12) Branches: 93.1% (27/29)

eyeamkd commented 1 month ago

Test Coverage Report

Lines: 100% (75/75) Statements: 100% (83/83) Functions: 100% (12/12) Branches: 93.1% (27/29)

eyeamkd commented 1 month ago

Test Coverage Report

Lines: 100% (75/75) Statements: 100% (83/83) Functions: 100% (12/12) Branches: 93.1% (27/29)

balajikummari commented 1 month ago

should improve type system for publishing experiments

publishExperimentResult("", "", backendUrl, eventType);

this is not good.

here is a sample type system that I was talking about on call, that has good type safety powred by TS inference

image

image

image

image

image

eyeamkd commented 1 month ago

Test Coverage Report

Lines: 89.53% (77/86) Statements: 89.47% (85/95) Functions: 92.3% (12/13) Branches: 86.66% (26/30)