[#91] Enhance RSocketGateway to support authentication.

scalecube / scalecube-gateway

ScaleCube API Gateway is the single entry point for service consumers. handles incoming requests and proxy/route to the appropriate microservice instance.

Apache License 2.0

18 stars 7 forks source link

[#91] Enhance RSocketGateway to support authentication. #92

Closed snripa closed 4 years ago

snripa commented 5 years ago

Generalize gateway events handler and apply same logic to RSocket Gateway.

Fixes https://github.com/scalecube/scalecube-gateway/issues/91

dmytro-lazebnyi commented 4 years ago

In general, looks good to me.

I would only change following non-crucial thing:

create GatewaySession interface (currently with method sessionId() only) and implement it by WebsocketGatewaySession and RSocketGatewaySession
use GatewaySession interface type instead of SESSION generic type in SessionEventsHandler (in this case you also can safely remove sessionId(SESSION session) method)